[Automation] Add CI linters/checks

[okdas]

Description

Adding linters and static checkers to CI rotation.

Issue

CI part of #175

Type of change

Please mark the options that are relevant.

• New feature, functionality or library
• Bug fix (non-breaking change which fixes an issue)
• Code health or cleanup
• Major breaking change
• Documentation
• Other: <REPLACE_ME>

List of changes

• Adding more checks for CI

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have tested my changes using the available tooling
• If applicable, I have made corresponding changes to related local or global README
• If applicable, I have added new diagrams using mermaid.js
• If applicable, I have added tests that prove my fix is effective or that my feature works

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@58bc07f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage        ?   40.46%           
=======================================
  Files           ?       26           
  Lines           ?     1913           
  Branches        ?        0           
=======================================
  Hits            ?      774           
  Misses          ?     1082           
  Partials        ?       57           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Olshansk]

Please update the PR description.

[Olshansk]

@okdas We might be doing a techdebt "bug bash" next week. Do you think it'd be possible to have a baseline implementation of this that we can build on / add to?

[okdas]

Do you think it'd be possible to have a baseline implementation of this that we can build on / add to?

Yes, if this is not going to be ready by then I will export linters output we can go through together.

[Olshansk]

@okdas Just wanted to follow up if there are any blockers on this PR?

[okdas]

@okdas Just wanted to follow up if there are any blockers on this PR?

No blockers, will pick it up soon.

[Olshansk]

I think you can change this from a draft to a real PR.

[Olshansk]

@okdas Do you need another review on this or is it still a WIP?

[okdas]

@okdas Do you need another review on this or is it still a WIP?

this is ready for review now, thanks!

[Olshansk]

Left a few some suggestions/comments throughout but looking forward to getting this in!

Very well designed and documented!

[Olshansk]

@okdas Lmk when I should re-review here.

Someone on the team will likely need to a single followup PR because it looks like we caught a bunch of stuff :)

[okdas]

@Olshansk you can re-review now.

Someone on the team will likely need to a single followup PR because it looks like we caught a bunch of stuff :)

Haha, yes!

Here's an example of golangci-lint run --fix changes: https://github.com/pokt-network/pocket/compare/dk-add-linters...dk-add-linters-autofix?expand=1 - some of the issues can be fixed automatically.

Note: we have a very limited number of linters turned on! If you want to go crazy you could run golangci-lint run --enable-all --fix - just beware this changes lots of files, some linters can be redundant, and in order to run this command you'd need to comment out enabled: [] section in .golangci.yml file.

[Olshansk]

@okdas

1. Next time, please make sure to "re-request review" when something is ready to be re-reviewed:

2. I left one open comment. please update it before merging