Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket #211: finding unnecessary public functions in the Persistence Module #320

Merged
merged 36 commits into from
Nov 14, 2022
Merged

Ticket #211: finding unnecessary public functions in the Persistence Module #320

merged 36 commits into from
Nov 14, 2022

Commits on Oct 24, 2022

  1. #211 find unnecessary public func

    @Jasonyou1995
    Jasonyou1995 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5a8f9fe View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Keep the GetParameters for future implemenation 

    Keep this function
    @Jasonyou1995
    Jasonyou1995 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    347ef7f View commit details
    Browse the repository at this point in the history

  2. Update application.go 

    DeleteApp function removed.
    @Jasonyou1995
    Jasonyou1995 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    edde382 View commit details
    Browse the repository at this point in the history

  3. Update persistence_genesis.go 

    The GetParameteres need to be implemented.
    @Jasonyou1995
    Jasonyou1995 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9a7a2ff View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue/211/persistence-module-lowercase-funct… 

    …ions-149
    @Jasonyou1995
    Jasonyou1995 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9596ab0 View commit details
    Browse the repository at this point in the history

  5. merge to main

    @Jasonyou1995
    Jasonyou1995 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8df520c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. update functions that can be private

    @Jasonyou1995
    Jasonyou1995 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0ccd1f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. remove redundant files

    @Jasonyou1995
    Jasonyou1995 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    e8681ef View commit details
    Browse the repository at this point in the history

  2. remote redundant proto files

    @Jasonyou1995
    Jasonyou1995 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    6ca5ff0 View commit details
    Browse the repository at this point in the history

  3. clean redundant files

    @Jasonyou1995
    Jasonyou1995 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2fa470a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue/211/persistence-module-lowercase-funct… 

    …ions-149
    @Jasonyou1995
    Jasonyou1995 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    be0d5c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. add to changelog and fix format issue

    @Jasonyou1995
    Jasonyou1995 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    d1561f1 View commit details
    Browse the repository at this point in the history

  2. Adding FAQ document 

    Added in `docs/development/FAQ.md`
    @Jasonyou1995
    Jasonyou1995 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e42b1f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. clean code base in persistence/test/ 

    Lowering code exposure in persistence/test by lowercase non-public functions
    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5149bac View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG 

    Adding lowercase functions to persistence/docs/CHANGELOG
    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f218938 View commit details
    Browse the repository at this point in the history

  3. Clean persistence/types code base 

    Lowercase functions that don't need to be exported
    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    92363fc View commit details
    Browse the repository at this point in the history

  4. Removing unnecessary space and newline in comments 

    Only updated comments in /persistence repo
    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    43602f0 View commit details
    Browse the repository at this point in the history

  5. Update docs/development/FAQ.md 

    Co-authored-by: Daniel Olshansky <[email protected]>
    @Jasonyou1995 @Olshansk
    Jasonyou1995 and Olshansk authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    90bcd9d View commit details
    Browse the repository at this point in the history

  6. Update docs/development/FAQ.md 

    Co-authored-by: Daniel Olshansky <[email protected]>
    @Jasonyou1995 @Olshansk
    Jasonyou1995 and Olshansk authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    993dee4 View commit details
    Browse the repository at this point in the history

  7. Add consolidate TODO common for CHANGELOG

    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e0e2b91 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary space in comments

    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d0da787 View commit details
    Browse the repository at this point in the history

  9. Revert "clean code base in persistence/test/" 

    This reverts commit 5149bac.
    @Jasonyou1995
    Jasonyou1995 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9fdfacd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Daniel Olshansky <[email protected]>
    @Jasonyou1995 @Olshansk
    Jasonyou1995 and Olshansk authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3d1a95d View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @Jasonyou1995
    Jasonyou1995 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    837f08d View commit details
    Browse the repository at this point in the history

  3. Update test

    @Jasonyou1995
    Jasonyou1995 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9db4b05 View commit details
    Browse the repository at this point in the history

  4. Functions update in test package (non-test functions)

    @Jasonyou1995
    Jasonyou1995 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    936c544 View commit details
    Browse the repository at this point in the history

  5. Revert "Functions update in test package (non-test functions)" 

    This reverts commit 936c544.
    @Jasonyou1995
    Jasonyou1995 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    198ce48 View commit details
    Browse the repository at this point in the history

  6. Test functions update

    @Jasonyou1995
    Jasonyou1995 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    e720e02 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. rpc file added

    @Jasonyou1995
    Jasonyou1995 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b8b4ef0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @Jasonyou1995
    Jasonyou1995 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3c2c6d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'main' into issue/211/persistence-module-lowercase-funct… 

    …ions-149
    @Jasonyou1995
    Jasonyou1995 authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    51b2ed1 View commit details
    Browse the repository at this point in the history

  2. Delete client.gen.go

    @Jasonyou1995
    Jasonyou1995 authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4ef818b View commit details
    Browse the repository at this point in the history

  3. Delete server.gen.go

    @Jasonyou1995
    Jasonyou1995 authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    ebf05ed View commit details
    Browse the repository at this point in the history

  4. Update .gitignore

    @Jasonyou1995
    Jasonyou1995 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    3dcfc8d View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Daniel Olshansky <[email protected]>
    @Jasonyou1995 @Olshansk
    Jasonyou1995 and Olshansk authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    636d550 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Update .gitignore

    @Jasonyou1995
    Jasonyou1995 committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    258ecb4 View commit details
    Browse the repository at this point in the history