-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Investigate memory leaks, manual GC on ResetToGenesis - (Issue #440) #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deblasis
added
bug
Something isn't working - expected behaviour is incorrect
core
Core infrastructure - protocol related
code health
Nice to have code improvement
labels
Jan 18, 2023
Olshansk
approved these changes
Jan 20, 2023
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
## [0.0.0.23] - 2023-01-18 | |||
|
|||
- Consolidate the `Block` proto structures under `shared/core/types` | |||
- Added `debug.FreeOSMemory()` on `ResetToGenesis` to free-up memory and stabilize `LocalNet`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob need to update this now
…investigation Signed-off-by: Alessandro De Blasis <[email protected]>
Olshansk
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome documentation, ty!
Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working - expected behaviour is incorrect
code health
Nice to have code improvement
core
Core infrastructure - protocol related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reclaims memory manually after the memory-churn intensive operations performed during a
ResetToGenesis
debug commandIn particular:
This is the result of my initial investigation #440 (comment)
Issue
This might fix #440 but I'd like another pair of eyes on this to understand if this is the right approach
Type of change
Please mark the relevant option(s):
List of changes
debug.FreeOSMemory()
after cleaning up the persistence structuresTesting
make develop_test
README
Required Checklist
If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)