[Infra] Add app/servicer keys to LocalNet genesis

[adshmh]

Description

Summary generated by Reviewpad on 01 Jun 23 18:05 UTC

This pull request adds 2 applications and 2 servicers to the genesis.json file for LocalNet configuration, which can be used for testing the CLI. It is part of work on issue #754. The patch includes changes to the CHANGELOG.md and README.md files to reflect the added addresses. The relevant options for this pull request are "Documentation" and "Other," specifically "added 2 applications and 2 servicers to genesis.json for LocalNet."

Issue

Part of work on #754

Type of change

Please mark the relevant option(s):

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Major breaking change
• Documentation
• Other Added 2 applications and 2 servicers to genesis.json for LocalNet

List of changes

• Added 2 applications to genesis.json for LocalNet
• Added 2 servicers to genesis.json for LocalNet

Testing

• make develop_test; if any code changes were made
• make test_e2e on k8s LocalNet; if any code changes were made
• e2e-devnet-test passes tests on DevNet; if any code was changed
• Docker Compose LocalNet; if any major functionality was changed or introduced
• k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• I have tested my changes using the available tooling
• I have updated the corresponding CHANGELOG

If Applicable Checklist

• I have updated the corresponding README(s); local and/or global
• I have added tests that prove my fix is effective or that my feature works
• I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[Olshansk]

A couple small NITs but otherwise LGTM. Once CI passes, the pattern we use is "Squash & Merge" and copy-paste the PR description into the commit message.

[Olshansk]

Suggested change

	Applications with the following addresses are staked on LocalNet, through [applications field of the genesis.json in the configuration](https://github.com/pokt-network/pocket/blob/main/build/localnet/manifests/configs.yaml#L4088)
	Applications with the following addresses are staked on LocalNet, through the [applications field of the genesis.json in the LocalNet configuration](https://github.com/pokt-network/pocket/blob/main/build/localnet/manifests/configs.yaml#L4088)

[adshmh]

Thank you for the review. Fixed.

[Olshansk]

Suggested change

	Servicers with the following addresses are staked on LocalNet, through [servicers field of the genesis.json in the configuration](https://github.com/pokt-network/pocket/blob/main/build/localnet/manifests/configs.yaml#L4120)
	Servicers with the following addresses are staked on LocalNet, through the [servicers field of the genesis.json in the LocalNet configuration](https://github.com/pokt-network/pocket/blob/main/build/localnet/manifests/configs.yaml#L4120)

[adshmh]

Thank you for the review. Fixed.

[adshmh]

A couple small NITs but otherwise LGTM. Once CI passes, the pattern we use is "Squash & Merge" and copy-paste the PR description into the commit message.

Thank you for the review. Updated the commit message.

[Olshansk]

@adshmh I tried to review the changes since my last review and I'm guessing you git fooed to clean up some of your local commits.

It really helps the reviewer to see what changes took place between each review if we don't modify the git history, especially for PRs that are larger and take longer.

Per our review guidelines (#773), we always do a "squash and merge" when we merge the PR into main, so the history will be clean on main regardless.

[adshmh]

I tried to review the changes since my last review and I'm guessing you git fooed to clean up some of your local commits.

Sorry about that, wasn't local commits, did a push -f by mistake (the CI's timezone does not match mine, so CHANGELOG checks failed on CI after having passed locally).

[Olshansk]

I tried to review the changes since my last review and I'm guessing you git fooed to clean up some of your local commits.

Sorry about that, wasn't local commits, did a push -f by mistake (the CI's timezone does not match mine, so CHANGELOG checks failed on CI after having passed locally).

No worries. Regardless, see my previous comment here about merging it in.

Seems like you might need to merge with master first since there are merge conflicts since this was last reviewed.

[Olshansk]

@adshmh Did you still want to merge this in? If so, it's approved but you'll need to merge with main and resolve conflicts first. I also believe you have the proper github permissions to do so.

[Olshansk]

@adshmh Following up on an offline discussion around merge conflicts related to changelogs.

I took the liberty of resolving the conflict (and pushing the change) and recorded a video as a reference that we can have publically on the steps taken. Let me know if you have any follow up questions on this.

Screen.Recording.2023-06-01.at.11.04.36.AM.mov

[Olshansk]

Per our review guidelines (#773), we always do a "squash and merge" when we merge the PR into main, so the history will be clean on main regardless.

@adshmh Seems like everything is green so feel free to merge if you think it's ready!

[adshmh]

Per our review guidelines (#773), we always do a "squash and merge" when we merge the PR into main, so the history will be clean on main regardless.

@adshmh Seems like everything is green so feel free to merge if you think it's ready!

Done. Thanks!