Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vault_test.go #862

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Update vault_test.go #862

merged 1 commit into from
Jun 28, 2023

Conversation

okdas
Copy link
Member

@okdas okdas commented Jun 28, 2023

The latest tag was removed for some reason: docker-library/official-images@32c2455

Let's pin 1.13.3.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 28, 2023
@okdas okdas self-assigned this Jun 28, 2023
@okdas okdas requested a review from h5law June 28, 2023 17:30
@okdas okdas added the bug Something isn't working - expected behaviour is incorrect label Jun 28, 2023
h5law
h5law approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is something we will have to be updating manually from now on?

Otherwise LFG good spot! <3 Seems tests are working so lets :shipit:

@okdas
Copy link
Member Author

okdas commented Jun 28, 2023

Assuming this is something we will have to be updating manually from now on?

Most likely, but I'd treat hashicorp as a database. Meaning, the API that we use should only rarely change. We'd upgrade if this will be a problem, and I, personally, don't see that particular functionality being used often.

@okdas okdas merged commit 69a2860 into main Jun 28, 2023
@okdas okdas deleted the change-vault-image branch June 28, 2023 18:08
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into refactor/unicast-router
0d9b454 
* pokt/main:
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge branch 'refactor/unicast-router' into feat/integrate-bg-router
ed59461 
* refactor/unicast-router:
  chore: improve comment'
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge branch 'feat/integrate-bg-router' into chore/introduce-submodule
3ce4953 
* feat/integrate-bg-router: (21 commits)
  chore: improve comment'
  wip: docs: architecture diagrams
  chore: add TECHDEBT comment
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
  chore: return early
  chore: improve debug logging
  chore: improve comments
  chore: improve variable naming
  fix: `p2pModule#Send()` routing logic
  fix: interim background router bootstrapping
  chore: router logging improvements
  fix: return error
  chore: cleanup unused garbage
  chore: add missing godoc comments
  chore: add submodule TECHDEBT comments
  chore: comment cleanup
  chore: cleanup unused test utils
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  ...
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into HEAD
7cdc9e7 
* pokt/main:
  [P2P] refactor: unicast router (#844)
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge branch 'feat/integrate-bg-router' (early part) into chore/intro…
90fe9c4 
…duce-submodule

* 'feat/integrate-bg-router' (early part): (21 commits)
  test: fix raintree message target test
  [P2P] refactor: unicast router (#844)
  chore: add TECHDEBT comment
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
  chore: return early
  chore: improve debug logging
  chore: improve comments
  chore: improve variable naming
  fix: `p2pModule#Send()` routing logic
  fix: interim background router bootstrapping
  chore: router logging improvements
  fix: return error
  chore: cleanup unused garbage
  chore: add missing godoc comments
  chore: add submodule TECHDEBT comments
  chore: comment cleanup
  chore: cleanup unused test utils
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  ...
bryanchriswhite added a commit that referenced this pull request Jun 30, 2023
@bryanchriswhite
Merge branch 'feat/integrate-bg-router' into chore/introduce-submodule
05f8f91 
* feat/integrate-bg-router: (27 commits)
  chore: convert `DISCUSS_THIS_COMMIT` to `TECHDEBT`
  chore: remove warning log
  chore: add godoc comment
  docs: tweak P2P readme
  docs: update table of contents
  docs: update P2P readme
  test: fix raintree message target test
  [P2P] refactor: unicast router (#844)
  chore: add TECHDEBT comment
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
  chore: return early
  chore: improve debug logging
  chore: improve comments
  chore: improve variable naming
  fix: `p2pModule#Send()` routing logic
  fix: interim background router bootstrapping
  chore: router logging improvements
  fix: return error
  chore: cleanup unused garbage
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h5law h5law h5law approved these changes

Assignees

@okdas okdas

Labels
bug Something isn't working - expected behaviour is incorrect small Pull request is small waiting-for-review
Projects
V1 Dashboard
Status: Done
Milestone
M*: Pocket QoL (Quality of Life)
Development

Successfully merging this pull request may close these issues.
2 participants
@okdas @h5law