Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2P][Core] P2P Retries + Debug CLI Improvements #902

Merged
merged 11 commits into from
Jul 14, 2023
Merged

[P2P][Core] P2P Retries + Debug CLI Improvements #902

merged 11 commits into from
Jul 14, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jul 12, 2023 •
edited
Loading

Description

Revive docker-compose LocalNet by fixing a few issues on the client CLI, adding retries in P2P, while also making improvements to the debug CLI.

Issue

NA

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Update makefile so the CLI targets work
  • Split the debug commands into one that has a UI and one that is non-interactive
  • Add PrintNodeState and TriggerNextView to the debug command w/o a UI
  • Update a couple techdebt comments
  • Make p2p host connections retriable with a constant backoff

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the large Pull request is large label Jul 12, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed large Pull request is large labels Jul 12, 2023
@Olshansk Olshansk added bug Something isn't working - expected behaviour is incorrect p2p P2P specific changes testing Defining, adding, automating or modifying tests labels Jul 12, 2023
@Olshansk Olshansk marked this pull request as ready for review July 12, 2023 23:55
@Olshansk
Copy link
Member Author

/reviewpad summarize

@Olshansk Olshansk added the e2e-devnet-test Runs E2E tests on devnet label Jul 13, 2023
@Olshansk Olshansk changed the title Applying diff [P2P][Core] P2P Retries + Debug CLI Improvements Jul 13, 2023
@Olshansk Olshansk self-assigned this Jul 13, 2023
@Olshansk Olshansk requested a review from dylanlott July 13, 2023 00:18
dylanlott
dylanlott reviewed Jul 13, 2023
View reviewed changes
app/client/cli/debug.go Outdated Show resolved Hide resolved
@Olshansk Olshansk requested a review from dylanlott July 13, 2023 00:37
dylanlott
dylanlott approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

bryanchriswhite
bryanchriswhite reviewed Jul 13, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
bryanchriswhite
bryanchriswhite reviewed Jul 13, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
bryanchriswhite
bryanchriswhite reviewed Jul 13, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
bryanchriswhite
bryanchriswhite requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! 🙌

I had some questions and suggestions but those notwithstanding, I'm confident that the CLI appreciates the love. ❤️

@Olshansk Olshansk mentioned this pull request Jul 13, 2023
Merged
20 tasks
bryanchriswhite
bryanchriswhite reviewed Jul 14, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
bryanchriswhite
bryanchriswhite approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple more comments but otherwise approving, I trust your judgement 👍 😅

@Olshansk Olshansk mentioned this pull request Jul 14, 2023
Open
11 tasks
@Olshansk Olshansk merged commit 5c028e8 into main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanlott dylanlott dylanlott approved these changes

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

@okdas okdas Awaiting requested review from okdas

Assignees

@Olshansk Olshansk

Labels
bug Something isn't working - expected behaviour is incorrect e2e-devnet-test Runs E2E tests on devnet medium Pull request is medium p2p P2P specific changes testing Defining, adding, automating or modifying tests waiting-for-review
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

Successfully merging this pull request may close these issues.
3 participants
@Olshansk @bryanchriswhite @dylanlott