[Tooling] Retrieve keys for all actors from k8s secrets #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 14 Jul 23 23:17 UTC
This pull request includes a series of patches that make changes to the file
debug.go
in theshared/k8s
directory.Patch 1/5: The patch retrieves keys for all actors from k8s secrets. It adds support for retrieving private keys for validators, servicers, fisherman, and applications.
Patch 2/5: This patch fixes a linter error in the
fetchPrivateKeys
function by updating the function signature to use a single string parameter forresourceName
andactor
.Patch 3/5: This patch further fixes linter errors in the same function and shortens the code by removing unnecessary switch cases.
Patch 4/5: This patch updates the constant for the secret resource name from
privateKeysSecretResourceNameFisherman
toprivateKeysSecretResourceNameFishermen
.Patch 5/5: This patch fixes a typo in the function name
FetchFishermanPrivateKeys
by updating the privateKeysSecretResourceName toprivateKeysSecretResourceNameFishermen
.Please review these changes and ensure they are appropriate.
Issue
Added as a TODO in #869:
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)