Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] update LocalNet servicers' URLs #921

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Jul 20, 2023

Description

Update servicers' URLs in LocalNet configuration.

Issue

Part of work on #869

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Updated LocalNet's config in manifests
  • Updated Helm charts template

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@adshmh adshmh added the infra Core infrastructure - not protocol related label Jul 20, 2023
@adshmh adshmh self-assigned this Jul 20, 2023
@adshmh adshmh requested a review from okdas July 20, 2023 14:01
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 20, 2023
@adshmh adshmh merged commit 3d2f9b3 into main Jul 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure - not protocol related small Pull request is small waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants