Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence] Adds node subcommand to CLI #935

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jul 24, 2023

Description

Adds the first step of the CLI harness for save and load E2E testing. This PR is the first of a series and will be followed by additional PRs adding the actual sub-command logic and execution.

node keyword was chosen contrary to #566 as per the Discussion in Discord.

image

Issue

Relates to a series of changes to address #566

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Adds the node sub-command to the app CLI.

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the large Pull request is large label Jul 24, 2023
@dylanlott dylanlott changed the base branch from main to persistence/save-load July 24, 2023 18:44
@dylanlott dylanlott changed the base branch from persistence/save-load to persistence/savepoints-initial July 24, 2023 18:44
@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jul 24, 2023
@dylanlott dylanlott self-assigned this Jul 24, 2023
@dylanlott dylanlott marked this pull request as ready for review July 24, 2023 18:49
@dylanlott dylanlott requested review from Olshansk and h5law July 24, 2023 18:52
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm. Any reason we can't base this against main instead of persistence/savepoints-initial?

@dylanlott dylanlott changed the base branch from persistence/savepoints-initial to main July 25, 2023 02:15
@dylanlott dylanlott requested a review from Olshansk July 25, 2023 02:15
@dylanlott
Copy link
Contributor Author

Changes lgtm. Any reason we can't base this against main instead of persistence/savepoints-initial?

Absolutely none 😄 I had just been on savepoints-initial when I made the PR 👍 I dropped the others and updated the base branch. 🌴

Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are small looks good to me, unsure on the linter error but once thats figured out/fixed lets :shipit:

@dylanlott dylanlott merged commit c9049ef into main Jul 26, 2023
8 of 9 checks passed
@dylanlott dylanlott deleted the persistence/save-cli branch July 26, 2023 17:55
red-0ne pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants