-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Persistence] Adds node
subcommand to CLI
#935
Conversation
00d8ca9
to
c38976b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm. Any reason we can't base this against main instead of persistence/savepoints-initial
?
c38976b
to
0345dfc
Compare
Absolutely none 😄 I had just been on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are small looks good to me, unsure on the linter error but once thats figured out/fixed lets
0345dfc
to
f7242eb
Compare
Description
Adds the first step of the CLI harness for save and load E2E testing. This PR is the first of a series and will be followed by additional PRs adding the actual sub-command logic and execution.
node
keyword was chosen contrary to #566 as per the Discussion in Discord.Issue
Relates to a series of changes to address #566
Type of change
Please mark the relevant option(s):
List of changes
node
sub-command to the app CLI.Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)