-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Utility] Use TreeStore as source of truth #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h5law
added
utility
Utility specific changes
persistence
Persistence specific changes
e2e-devnet-test
Runs E2E tests on devnet
labels
Jul 25, 2023
Olshansk
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
reviewpad
bot
added
large
Pull request is large
and removed
medium
Pull request is medium
labels
Jul 26, 2023
dylanlott
reviewed
Jul 26, 2023
Olshansk
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e-devnet-test
Runs E2E tests on devnet
large
Pull request is large
persistence
Persistence specific changes
utility
Utility specific changes
waiting-for-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 26 Jul 23 11:24 UTC
This pull request includes the following changes:
In the
trees.go
file:Prove
that generates and verifies a proof against a tree name stored in theTreeStore
.GetTreeHashes
method to exclude the root tree from the map of tree names to their root hashes.In the
treestore_module.go
file:Prove
that generates and verifies a proof against a tree with a matching name.In the
transaction_test.go
file:TestHandleTransaction_ErrorAlreadyInMempool
,TestHandleTransaction_ErrorAlreadyCommitted
, andTestHandleTransaction_BasicValidation
.prepareEmptyIndexedTransaction
.In the
ibc_msg_mempool_test.go
file:TestHandleMessage_ErrorAlreadyCommitted
.In the
utility/transaction.go
file:github.com/pokt-network/pocket/shared/crypto
package.txHash
variable.u.GetBus().GetPersistenceModule().TransactionExists
.In the
persistence/trees/trees_test.go
file:TestTreeStore_Prove
and several test cases.treeStore
struct and the existing test function.In the
persistence_module.go
file:TransactionExists
and commented out the old method.Please let me know if you would like a more detailed review of any specific part of the diff.
Issue
Fixes #875
Type of change
Please mark the relevant option(s):
List of changes
TransactionExists
to use TreeStoreProve
method to TreeStoreTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)