Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] Create trustless_relay_validation.md #938

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Jul 26, 2023

Description

Add diagrams to describe validations done on trustless relays. Part of work on #918

Issue

Fixes #918

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Add a new markdown file to show trustless relay validations.

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@adshmh adshmh added documentation Improvements or additions to documentation utility Utility specific changes labels Jul 26, 2023
@adshmh adshmh self-assigned this Jul 26, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Jul 26, 2023
@adshmh adshmh requested review from Olshansk and h5law July 26, 2023 01:46
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
utility/doc/trustless_relay_validation.md Outdated Show resolved Hide resolved
@adshmh adshmh requested a review from Olshansk July 27, 2023 16:15
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was ready for another re-review, but it lgtm!

@adshmh adshmh merged commit 75e0ea6 into main Jul 31, 2023
9 checks passed
red-0ne pushed a commit that referenced this pull request Aug 2, 2023
## Description

Add diagrams to describe validations done on trustless relays. Part of
work on #918

## Issue

Fixes #918 

## Type of change

Please mark the relevant option(s):

- [ ] New feature, functionality or library
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Major breaking change
- [X] Documentation
- [ ] Other <!-- add details here if it a different type of change -->

## List of changes

- Add a new markdown file to show trustless relay validations.

## Testing

- [ ] `make develop_test`; if any code changes were made
- [ ] `make test_e2e` on [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any code changes were made
- [ ] `e2e-devnet-test` passes tests on
[DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd);
if any code was changed
- [ ] [Docker Compose
LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
if any major functionality was changed or introduced
- [ ] [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any infrastructure or configuration changes were made

## Required Checklist

- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added, or updated, [`godoc` format
comments](https://go.dev/blog/godoc) on touched members (see:
[tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
- [ ] I have tested my changes using the available tooling
- [ ] I have updated the corresponding CHANGELOG

### If Applicable Checklist

- [ ] I have updated the corresponding README(s); local and/or global
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added, or updated,
[mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
README(s)
- [ ] I have added, or updated, documentation and
[mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
if I updated `shared/*`README(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation small Pull request is small utility Utility specific changes waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Documentation] E2E Relay Validation Documentation
3 participants