Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBC] Enable validators and thus IBC host creation in K8s #942

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Jul 27, 2023

Description

Summary generated by Reviewpad on 27 Jul 23 12:32 UTC

This pull request includes three patches.

Patch 1/3 enables the IBC module in k8s validators. It adds the "ibc" section to the values.yaml file and sets the "enabled" field to true. It also specifies the "stores_dir" path for IBC data and adds the "private_key" field for the IBC host, although it is marked as ignored.

Patch 2/3 enables validators and IBC Host creation. It modifies the cli-client.yaml and statefulset.yaml files, adding environment variables for the IBC host private key and enabling the validator and IBC modules.

Patch 3/3 adds generated helm docs. It updates the README.md file, removing the "ibc" section and updating the "validator" section with the "enabled" field.

Overall, these patches enable the IBC module, validators, and IBC host creation in the Pocket k8s chart, and add generated helm documentation.

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Update README
  • Enable validators config
  • Pass private key to IBC host

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law added infra Core infrastructure - not protocol related e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes labels Jul 27, 2023
@h5law h5law added this to the M7: Pocket NoS (North Star) milestone Jul 27, 2023
@h5law h5law requested review from Olshansk and okdas July 27, 2023 12:31
@h5law h5law self-assigned this Jul 27, 2023
@reviewpad reviewpad bot added the small Pull request is small label Jul 27, 2023
@h5law h5law merged commit 6736454 into main Jul 28, 2023
2 checks passed
@h5law h5law deleted the ibc/enable_in_k8s branch July 28, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes infra Core infrastructure - not protocol related small Pull request is small waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants