[Utility][Infra]Deploy an Anvil node in LocalNet #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adshmh
added
utility
|
@okdas in addition to review, could you please advise whether the labels I have added are correct? |
|
@adshmh I'll take a deeper look at this today, but at first glance this looks sweet 🔥 |
dylanlott
reviewed
Aug 8, 2023
| @@ -314,6 +314,16 @@ for x in range(localnet_config["full_nodes"]["count"]): | |||
|
|
|||
| k8s_resource("full-node-%s-pocket" % formatted_number, labels=["pocket-full-nodes"]) | |||
|
|
|||
| # Provisions anvil node and service for E2E testing | |||
dylanlott
reviewed
Aug 8, 2023
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
There was a problem hiding this comment.
Great comment, good to know 👍
dylanlott
reviewed
Aug 8, 2023
| @@ -314,6 +314,16 @@ for x in range(localnet_config["full_nodes"]["count"]): | |||
|
|
|||
| k8s_resource("full-node-%s-pocket" % formatted_number, labels=["pocket-full-nodes"]) | |||
|
|
|||
| # Provisions anvil node and service for E2E testing | |||
| k8s_yaml( | |||
| helm( | |||
There was a problem hiding this comment.
I'm getting an error coming form this line when trying to run this code locally .
Running: helm template anvil-node /Users/shakezula/dev/pokt/pocket/charts/anvil --include-crds
Error: Traceback (most recent call last):
/Users/shakezula/dev/pokt/pocket/build/localnet/Tiltfile:319:9: in <toplevel>
Error in helm: command "helm template anvil-node /Users/shakezula/dev/pokt/pocket/charts/anvil --include-crds" failed.
error: exit status 1
stdout: ""
stderr: "Error: template: anvil/templates/deployment.yaml:8:20: executing \"anvil/templates/deployment.yaml\" at <.Values.autoscaling.enabled>: nil pointer evaluating interface {}.enabled\n\nUse --debug flag to render out invalid YAML\n"
make: *** [localnet_down] Error 1
make localnet_up and make localnet_down are both reporting this error. Have you seen this error before, by chance?
dylanlott
suggested changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy an Anvil node as part of LocalNet to facilitate E2E tests.
Issue
Fixes #963, but using Anvil instead which has a feature set comparable to Ganache for our testing requirements. @dylanlott would appreciate any items you could add here.
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)