[Supplier] chore: improve supplier not found error message #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plier isn't on-chain
bryanchriswhite
added
supplier
Olshansk
reviewed
Nov 14, 2023
| @@ -52,7 +53,8 @@ func (k Keeper) Supplier(goCtx context.Context, req *types.QueryGetSupplierReque | |||
| req.Address, | |||
| ) | |||
| if !found { | |||
| return nil, status.Error(codes.NotFound, "not found") | |||
| msg := fmt.Sprintf("supplier with address %q", req.GetAddress()) | |||
There was a problem hiding this comment.
Going to think about how to iterate on this moving forward but just approving for now.
Olshansk
approved these changes
Nov 14, 2023
…d-error * pokt/main: [CI] Integrate E2E tests with GitHub CI (#152)
bryanchriswhite
added a commit
that referenced
this pull request
Nov 16, 2023
* relayer/cli: More tiny comment updates Added a couple more comments Update some comments and TODOs Update the names and references to queryNode/sequencerNode/fullNode etc Update pkg/relayer/cmd/cmd.go [Test] Updating `relay.feature` to run curl command to enable E2E Relay Test (#178) Updated comments for post 177+179 work for okdas Update OpenAPI spec Update .gitignore chore: update comment chore: move shared dependency setup logic to shared pkg chore: cleanup flags and dependencies for appgateserver cmd [Supplier] chore: improve supplier not found error message (#183) [CI] Integrate E2E tests with GitHub CI (#152)
bryanchriswhite
added a commit
that referenced
this pull request
Nov 16, 2023
…-update * merge/e2e_test/relay_x_relayer_cli: [LocalNet] Run Relayer and AppGateServer (#179) [Relay] E2E Relay Gaps (#177) More tiny comment updates Added a couple more comments Update some comments and TODOs Update the names and references to queryNode/sequencerNode/fullNode etc Update pkg/relayer/cmd/cmd.go [Test] Updating `relay.feature` to run curl command to enable E2E Relay Test (#178) Updated comments for post 177+179 work for okdas Update OpenAPI spec Update .gitignore chore: update comment chore: move shared dependency setup logic to shared pkg chore: cleanup flags and dependencies for appgateserver cmd [Supplier] chore: improve supplier not found error message (#183) [CI] Integrate E2E tests with GitHub CI (#152)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
* chore: improve error message seen by RPC consumers when the given supplier isn't on-chain * fix: query supplier test * chore: add todo comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Add context to the "key not found" error message that is returned when querying for a supplier which hasn't staked yet:
AI Summary
Summary generated by Reviewpad on 14 Nov 23 10:24 UTC
This pull request improves the error message seen by RPC consumers when the given supplier is not found on-chain. It adds a formatted message that includes the address of the supplier.
Issue
Type of change
Select one or more:
Testing
make go_develop_and_testSanity Checklist