-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Fix non-idempotency in (and speed up) supplier staking tests #815
[Testing] Fix non-idempotency in (and speed up) supplier staking tests #815
Conversation
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 815) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward 🛤️
Left a NIT, but otherwise LGTM.
…nt-stake-supplier * pokt/main: [Supplier] Initial slashing implementation (#795)
@Reviewer, here's the diff between 2f1af15..bedc05c:
|
syncing shared module param defaults led to additional fixes and refactoring in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love seeing prod related things take shape!!
…lier-stake-events * issues/799/e2e/param-helpers: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771) [Documentation] Change container names in the quickstart (#830)
…merge/integration-app_x_sup-stake-evts * issues/799/feat/supplier-stake-events: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit chore: review feedback improvements
… issues/799/tests/params * issues/799/merge/integration-app_x_sup-stake-evts: fix: add missing steps and update module name for moved param [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815) [Application] feat: app stake transfer (#743) Empty commit chore: review feedback improvements
## Summary - Rename `paramMap` type to `paramAnyMap` to improve readability and avoid local variable name collisions - Add missing parameter update assertion steps - Refactor event waiting E2E helpers ## Depends on - #815 ## Dependents - #820 - #826 ## Issue Mitigates silently failing parameter update steps. - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
## Summary Adds the following events: - `EventSupplierStaked` - `EventSupplierUnbondingBegin` - `EventSupplierUnbondingEnd` ## Depends on - #815 ## Dependents - #826 ## Issue Results in more robust supplier.feature steps. - #799 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
…rge/integration-app_x_transfer-period-base * issues/799/refactor/integration-app: fixup! HEAD^ fix: linter errors chore: review feedback improvements [SMST] feat: Use compact SMST proofs (#823) [SessionManager] Skip claims creation if supplier operator balance is too low (#817) chore: self-review improvements [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815)
…' into issues/657/chore/app-transfer-period * issues/657/merge/integration-app_x_transfer-period-base: fixup! HEAD^ fix: linter errors chore: review feedback improvements [SMST] feat: Use compact SMST proofs (#823) [SessionManager] Skip claims creation if supplier operator balance is too low (#817) chore: self-review improvements [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815)
## Summary Ports the `MsgUpdateParams` and `MsgUpdateParam` E2E tests to integration tests, improving execution speed and maintainability. ## Depends on - #827 - #820 - #821 - #815 ## Dependents - #809 ## Issue - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [x] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
#815) ## Summary - Fix non-idempotency in supplier staking tests; `supplier2` was not staked at the start but was left staked at the end. - Speed up supplier staking tests by updating the shared params to minimize the unbonding period to 1 session of 2 localnet/devnet blocks. ### NOTE: This is superseded by #826 where supplier un/staking E2E tests will be removed. ## Dependents - #821 - #820 - #826 ## Issue - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
## Summary - Rename `paramMap` type to `paramAnyMap` to improve readability and avoid local variable name collisions - Add missing parameter update assertion steps - Refactor event waiting E2E helpers ## Depends on - #815 ## Dependents - #820 - #826 ## Issue Mitigates silently failing parameter update steps. - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
## Summary Adds the following events: - `EventSupplierStaked` - `EventSupplierUnbondingBegin` - `EventSupplierUnbondingEnd` ## Depends on - #815 ## Dependents - #826 ## Issue Results in more robust supplier.feature steps. - #799 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
## Summary Ports the `MsgUpdateParams` and `MsgUpdateParam` E2E tests to integration tests, improving execution speed and maintainability. ## Depends on - #827 - #820 - #821 - #815 ## Dependents - #809 ## Issue - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [x] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
Summary
supplier2
was not staked at the start but was left staked at the end.NOTE: This is superseded by #826 where supplier un/staking E2E tests will be removed.
Dependents
Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist