Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Application] chore: add MsgUpdateParam to application module #844

Open
wants to merge 9 commits into
base: issues/612/gateway/logic
Choose a base branch
from
Open

[Application] chore: add MsgUpdateParam to application module #844

wants to merge 9 commits into from
+2,198 −253

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Sep 27, 2024 •
edited
Loading

Summary

ignite scaffold message update-param --module gateway --signer authority name as_type --response params

Adds the MsgUpdateParam message so that the application module may update individual parameters. The application module's min_stake param will be added in a subsequent PR.

Issue

Add individual param updates support to the application module

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Sep 27, 2024
@bryanchriswhite bryanchriswhite self-assigned this Sep 27, 2024
@bryanchriswhite bryanchriswhite mentioned this pull request Sep 27, 2024
Open
10 tasks
@bryanchriswhite bryanchriswhite linked an issue Sep 27, 2024 that may be closed by this pull request
[Utility] Minimum staking values for each actor #612
Open
10 tasks
@bryanchriswhite bryanchriswhite marked this pull request as ready for review September 27, 2024 09:49
red-0ne
red-0ne approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NITs and a linter error but otherwise LGTM.

x/application/simulation/update_param.go Outdated Show resolved Hide resolved
x/application/keeper/msg_server_update_param.go Outdated Show resolved Hide resolved
x/application/types/message_update_param_test.go Show resolved Hide resolved
@bryanchriswhite bryanchriswhite added the governance Governance related changes label Sep 27, 2024
bryanchriswhite and others added 3 commits September 30, 2024 11:13
@bryanchriswhite @red-0ne
chore: review feedback improvements
352afa1 
Co-authored-by: Redouane Lakrache <[email protected]>
@bryanchriswhite
fix: linter errors
6afdaef
@bryanchriswhite
Merge branch 'issues/612/gateway/logic' into issues/612/app/msg-updat…
d92eb59 
…e-param

* issues/612/gateway/logic:
  fix: test error message
  chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@bryanchriswhite bryanchriswhite

Labels
application Changes related to the Application actor consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. governance Governance related changes on-chain On-chain business logic
Projects
Shannon
Status: 👀 In review
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.

[Utility] Minimum staking values for each actor
2 participants
@bryanchriswhite @red-0ne