Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Application] Add min_stake application module param #845

Open
wants to merge 16 commits into
base: issues/612/app/msg-update-param
Choose a base branch
from
Open

[Application] Add min_stake application module param #845

wants to merge 16 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Sep 27, 2024 •
edited
Loading

Summary

  • Adds the min_stake application module param.
  • Adds missing validation unit test coverage around existing application module param, max_delegated_gateways.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Sep 27, 2024
@bryanchriswhite bryanchriswhite self-assigned this Sep 27, 2024
@bryanchriswhite bryanchriswhite added the governance Governance related changes label Sep 27, 2024
@bryanchriswhite bryanchriswhite mentioned this pull request Sep 27, 2024
Open
10 tasks
@bryanchriswhite
chore: add param update make targets and JSON msgs
cdff4b3
@bryanchriswhite
chore: add default application min_stake param of 1 POKT to genesis c…
be24753 
…onfig
@bryanchriswhite
chore: update MsgUpdateParamResponse & add AsUint64 AsType type
45b6e5c
@bryanchriswhite
feat: implement MsgUpdateParam handler
b3e139a
@bryanchriswhite
test: MsgUpdateParam handler
872202b
@bryanchriswhite
feat: implement NewMsgUpdateParam constructor
a49d69b
@bryanchriswhite
chore: add min_stake validation
d63a429
@bryanchriswhite
chore: tidy up
9040bf0
@bryanchriswhite
Merge branch 'issues/612/app/msg-update-param' into issues/612/applic…
497ecd9 
…ation/min-stake-param

* issues/612/app/msg-update-param:
  fix: linter errors
  chore: review feedback improvements

# Conflicts:
#	x/application/keeper/msg_server_update_param.go
@bryanchriswhite
Merge branch 'issues/612/app/msg-update-param' into issues/612/applic…
941b801 
…ation/min-stake-param

* issues/612/app/msg-update-param:
  fix: test error message
  chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs] Update README(s) (#842)
@bryanchriswhite
chore: update message_update_param_test.go
36e5f2e
@bryanchriswhite bryanchriswhite marked this pull request as ready for review September 30, 2024 11:37
@bryanchriswhite bryanchriswhite requested review from Olshansk and red-0ne and removed request for Olshansk September 30, 2024 11:37
@bryanchriswhite bryanchriswhite linked an issue Sep 30, 2024 that may be closed by this pull request
[Utility] Minimum staking values for each actor #612
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne Awaiting requested review from red-0ne

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@bryanchriswhite bryanchriswhite

Labels
application Changes related to the Application actor consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. governance Governance related changes on-chain On-chain business logic
Projects
Shannon
Status: 👀 In review
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.

[Utility] Minimum staking values for each actor
1 participant
@bryanchriswhite