Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application] Enforce minimum stake when staking #847

Draft
wants to merge 4 commits into
base: issues/612/application/min-stake-param
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

Summary

  1. Adds minimum stake validation to the application stake message handler (i.e. total stake must be >= minimum stake).
  2. Updates error returns in the same handler to ensure all error paths return appropriate gRPC status errors.
  3. Replaces some warn and error level logs with info level, which I believe is more appropriate (until we have a practical debug level, at which point they should become debug logs).

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor protocol General core protocol related changes on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Sep 30, 2024
@bryanchriswhite bryanchriswhite self-assigned this Sep 30, 2024
@bryanchriswhite bryanchriswhite linked an issue Sep 30, 2024 that may be closed by this pull request
10 tasks
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 847)
Grafana network dashboard for devnet-issue-847

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Changes related to the Application actor consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e on-chain On-chain business logic protocol General core protocol related changes push-image CI related - pushes images to ghcr.io
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

[Utility] Minimum staking values for each actor
1 participant