feat: Do not panic when casting from an empty Series to pl.Decimal #14330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14002
More specifically, the PR attempts to address the following two issues:
1. Panic when casting from an empty Series without explicitly setting a scale:
In this case, we just set scale to 0, in the same way as it's done when constructing an empty Series with
dtype=pl.Decimal
:2. An error is raised when casting a Series, whose dtype is already pl.Decimal, without setting scale explicitly:
I don't know why anyone would want to do that but raising an error seems too punishing; the existing scale can be kept. For example: