Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Define what a 'character' means in slice / len_chars #14395

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Feb 9, 2024

Closes #10349

Credit to @mcrumiller who signalled this issue and started this in #10339. I am splitting this out as the implementation of the str.head/tail should not block this doc improvement.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Feb 9, 2024
@stinodego stinodego marked this pull request as ready for review February 9, 2024 20:06
@mcrumiller
Copy link
Contributor

Ahh geez I forgot about that one. I couldn't figure out how to negative index on head/tail at the time, but now that @reswqa has expressified str.slice we should be able to just piggyback on his work and add those fairly easily.

@stinodego
Copy link
Member Author

stinodego commented Feb 9, 2024

Ahh geez I forgot about that one. I couldn't figure out how to negative index on head/tail at the time, but now that @reswqa has expressified str.slice we should be able to just piggyback on his work and add those fairly easily.

I just accepted the head/tail issue - do you want to revisit that PR? The feature is welcome :)

@mcrumiller
Copy link
Contributor

Sure thing @stinodego -- once I finish my "real" work which is usually not as fun.

@stinodego stinodego merged commit a53ab11 into main Feb 9, 2024
13 checks passed
@stinodego stinodego deleted the chars branch February 9, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define "character" in str.slice docstring
2 participants