Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change print to warn in reading csv from python file like object #14469

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

deanm0000
Copy link
Collaborator

I noticed when reading csv files from inside a zip archive that it kept "warning" that I shouldn't do that and that I couldn't ignore the warning because it was printing rather than warning.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ritchie46 ritchie46 changed the title fix(rust): change print to warn in reading csv from python file like object feat: change print to warn in reading csv from python file like object Feb 13, 2024
@ritchie46 ritchie46 merged commit df99164 into pola-rs:main Feb 13, 2024
14 checks passed
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Feb 13, 2024
@deanm0000 deanm0000 deleted the warn_instead_of_print_csv branch August 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants