Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't panic on hashing nested list types #16555

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: Don't panic on hashing nested list types #16555

merged 1 commit into from
May 28, 2024

Conversation

ritchie46
Copy link
Member

fixes #16553

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.49%. Comparing base (52c919f) to head (94ab793).

Files Patch % Lines
crates/polars-core/src/series/mod.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16555      +/-   ##
==========================================
+ Coverage   81.46%   81.49%   +0.03%     
==========================================
  Files        1412     1412              
  Lines      185465   185474       +9     
  Branches     2996     2996              
==========================================
+ Hits       151084   151150      +66     
+ Misses      33865    33808      -57     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cb40bbd into main May 28, 2024
27 checks passed
@ritchie46 ritchie46 deleted the hash branch May 28, 2024 18:18
@Aryik
Copy link

Aryik commented May 30, 2024

@ritchie46 thanks for the quick fix! Any idea when this will make it into a release on pypi or how I can work around this issue? I'm running into this in prod after upgrading to polars 0.20.30

@stinodego
Copy link
Member

@ritchie46 thanks for the quick fix! Any idea when this will make it into a release on pypi or how I can work around this issue? I'm running into this in prod after upgrading to polars 0.20.30

There will be a new release later this week or start of next week.

Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyFrames containing nested List types will cause panic in collect()
3 participants