-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: JSON encoding in the root expression namespace pl.Expr.json_encode
#18396
Closed
tim-stephenson
wants to merge
10
commits into
pola-rs:main
from
tim-stephenson:universal_json_encode
Closed
feat: JSON encoding in the root expression namespace pl.Expr.json_encode
#18396
tim-stephenson
wants to merge
10
commits into
pola-rs:main
from
tim-stephenson:universal_json_encode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t namespace. added ignore_nulls as an option for json_encode (though did not implement it yet)
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
Aug 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18396 +/- ##
==========================================
- Coverage 79.84% 79.80% -0.04%
==========================================
Files 1496 1497 +1
Lines 200333 200407 +74
Branches 2841 2843 +2
==========================================
- Hits 159952 159938 -14
- Misses 39856 39944 +88
Partials 525 525 ☔ View full report in Codecov by Sentry. |
@tim-stephenson will this be finished? Otherwise we must close it because of the clutter. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closing-candidate
PR's/issue candidate for closing
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
json_encode
to the root expression & series namespace. This maps a column of any polars type (besides the object type) into a string column with it's corresponding JSON encoding.Prior PR which only added it to the list namespace:
pl.Expr.list.json_encode()
#18353Issues asking for this feature:
json_encode
topl.List
#14029Current PR adding the
ignore_nulls
option tojson_encode
. I added (but did not yet implement) this option to thejson_encode
function I added.ignore_nulls
option tostruct.json_encode
#17867