Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Scan from BytesIO in new-streaming parquet source #18643

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

nameexhaustion
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 10, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review September 10, 2024 05:38
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (5ccb238) to head (5327254).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/parquet_source.rs 0.00% 29 Missing ⚠️
crates/polars-plan/src/plans/ir/scan_sources.rs 0.00% 13 Missing ⚠️
crates/polars-io/src/utils/byte_source.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18643      +/-   ##
==========================================
- Coverage   79.91%   79.89%   -0.03%     
==========================================
  Files        1506     1506              
  Lines      203182   203204      +22     
  Branches     2891     2891              
==========================================
- Hits       162377   162344      -33     
- Misses      40255    40310      +55     
  Partials      550      550              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

One rebase away...

@ritchie46 ritchie46 merged commit 832aa53 into pola-rs:main Sep 10, 2024
21 checks passed
@nameexhaustion nameexhaustion deleted the pq-s-source branch September 11, 2024 08:04
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants