Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Allow fill_null to be used with torch tensors #19120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Niko32
Copy link

@Niko32 Niko32 commented Oct 7, 2024

When trying to use df.fill_null with a value that is a torch tensor I have encountered an unexpected error. I traced it back to some code that would assume a value with an attribute item to be a numpy object.

This is a simple fix for this issue.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (addaf83) to head (28e7fc7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19120      +/-   ##
==========================================
- Coverage   79.81%   79.80%   -0.01%     
==========================================
  Files        1531     1531              
  Lines      208596   208595       -1     
  Branches     2913     2914       +1     
==========================================
- Hits       166482   166475       -7     
- Misses      41563    41569       +6     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant