Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Workaround for rust-analyzer bug #19134

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 8, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (1f48036) to head (da60492).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pipe/src/executors/sinks/group_by/primitive/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19134   +/-   ##
=======================================
  Coverage   79.78%   79.79%           
=======================================
  Files        1531     1531           
  Lines      208427   208446   +19     
  Branches     2913     2913           
=======================================
+ Hits       166295   166325   +30     
+ Misses      41581    41570   -11     
  Partials      551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion
Copy link
Collaborator

So it wasn't just me 😄

@orlp
Copy link
Collaborator Author

orlp commented Oct 8, 2024

@nameexhaustion Nope, I got fed up so here it is :)

@orlp orlp merged commit 133bf47 into pola-rs:main Oct 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants