fix: Invalid selectors not being recognized #19136
Open
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19136 +/- ##
==========================================
- Coverage 79.78% 79.76% -0.03%
==========================================
Files 1531 1531
Lines 208427 208446 +19
Branches 2913 2913
==========================================
- Hits 166295 166262 -33
- Misses 41581 41633 +52
Partials 551 551 ☔ View full report in Codecov by Sentry. |
pavelzw
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Oct 8, 2024
| def test_invalid_selector() -> None: | ||
| df = pl.DataFrame(data={"x": [1, 2], "z": ["a", "b"]}) | ||
| with pytest.raises(InvalidOperationError, match="invalid selector expression"): | ||
| df.drop(pl.col("x", "z") + 2) # type: ignore[arg-type] |
There was a problem hiding this comment.
❯ mypy py-polars/tests/unit/test_selectors.py
py-polars/tests/unit/test_selectors.py:822: error: Argument 1 to "drop" of "DataFrame" has incompatible type "Expr"; expected "str | _selector_proxy_ | Iterable[str | _selector_proxy_]" [arg-type]
py-polars/tests/unit/test_selectors.py:824: error: Argument 1 to "drop" of "DataFrame" has incompatible type "Expr"; expected "str | _selector_proxy_ | Iterable[str | _selector_proxy_]" [arg-type]
Found 2 errors in 1 file (checked 1 source file)
There was a problem hiding this comment.
Then I think we must pass a seelctor as we don't allow expression inputs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19023