Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update apollo #1018

Merged
merged 4 commits into from
Oct 26, 2021
Merged

chore: update apollo #1018

merged 4 commits into from
Oct 26, 2021

Conversation

bchrobot
Copy link
Member

@bchrobot bchrobot commented Oct 18, 2021 •
edited
Loading

Description

Updates Apollo client and server to v3, along with associated utils.

Motivation and Context

Developing with loadData is incredibly painful and error prone. Can't go back after hooks...

The Server-side -> async creator changes are because await graphqlServer.start() has to be called before it can used with express middleware.

How Has This Been Tested?

This has been tested pretty extensively locally.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation Changes

N/A

Checklist:

  • My code follows the code style of this project.
  • My commit messages follow the Conventional Commits specification.
  • My change requires a change to the documentation.
  • I have included updates for the documentation accordingly.

@bchrobot bchrobot marked this pull request as ready for review October 18, 2021 13:47
ben-pr-p
ben-pr-p approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@ben-pr-p ben-pr-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - let's just make sure to progressively roll it out early in the week :)

@bchrobot bchrobot merged commit 8b74853 into master Oct 26, 2021
@bchrobot bchrobot deleted the chore-update-apollo branch October 26, 2021 14:08
@bchrobot bchrobot mentioned this pull request Nov 3, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-pr-p ben-pr-p ben-pr-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchrobot @ben-pr-p