feat(campaign-interaction-steps): add save button to top of section #1610
Conversation
| <Box m={2}> | ||
| <ScriptPreviewButton campaignId={campaignId} /> | ||
| </Box> | ||
| <div style={{ display: "flex", justifyContent: "space-between" }}> |
There was a problem hiding this comment.
I looked through the onboarding and contributing docs but didn't see any guidance around css/styling, so I kept this as an inline change for simplicity's sake. I'm happy to change it if there's a convention I should be following, lmk!
There was a problem hiding this comment.
Yeah agree on no real convention. I've followed a rule of thumb of if it goes over one line - pull it out of the body. Curious if @hiemanshu has thoughts around this too.
There was a problem hiding this comment.
Suggestion: See if you can use a Grid with Grid items to get the same outcome. See example here . Inline CSS for the div with Box containers for the buttons feels mismatched I think.
There was a problem hiding this comment.
There is no convention. We should pick one! My suggestion would be single style can go inline, anymore, goes to makeStyles hooks.
|
Maybe this is a follow-up issue / PR, but I wonder if this Save button should just save, rather than "Save and goto next section", since the section collapse toggle button is right there. If we decide that's a good idea, I would rename the button to "Save interactions" |
agree with this suggestion and think it can happen in this PR! |
…stead of save and goto next #1547
hiemanshu
deleted the
feat/add-save-button-to-top-of-interacion-steps
branch
…olitics-rewired#1610) * feat(campaign-interaction-steps): add save button to top of section
Description
This pr adds the save button at the bottom of the interaction steps section of a campaign to the top of the section as well, so that users can scroll up to save when editing campaigns with long scripts
Motivation and Context
It closes #1547
How Has This Been Tested?
Locally
Screenshots (if appropriate):
Documentation Changes
n/a
Checklist: