fix: create campaign speed dial open/close behavior #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiemanshu
approved these changes
Jun 21, 2023
ajohn25
approved these changes
Jun 21, 2023
hiemanshu
force-pushed
the
fix/create-campaign-speed-dial-close-behavior
branch
from
6811525
to
87f34ca
Compare
ajohn25
pushed a commit
to With-the-Ranks/Spoke
that referenced
this pull request
Sep 10, 2024
…#1627) * fix: unclear tooltip titles for create menu --------- Co-authored-by: Hiemanshu Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completed one of the stretch goals of the ticket:
Made it say “+ Create a campaign” when the actions are not showing and keep the “X” when the actions are showing
@mkoontz-rewired Make sure to write up a ticket for the stretch goal of "Move it to the top of the page to the right of "Current" and left of "Release all unhandled replies". At the moment, these buttons won't be absolutely positioned."/ a ticket for Kenny to re-consider the create flow in general
Design ticket created: https://app.asana.com/0/1202110006089866/1204849793973501
Motivation and Context
Closes #1564
How Has This Been Tested?
locally
Screenshots (if appropriate):
Documentation Changes
Checklist: