-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(10dlc): add additional notices #1645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchrobot
previously requested changes
Jul 27, 2023
src/containers/AdminDashboard/components/Register10DlcNoticeCard.tsx
Outdated
Show resolved
Hide resolved
lediur
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general notes and questions.
nit: would it make sense to extract pricing copy into shared components?
src/components/NoticeText/CampaignRegistration10DlcNoticeText.tsx
Outdated
Show resolved
Hide resolved
src/components/NoticeText/CampaignRegistration10DlcNoticeText.tsx
Outdated
Show resolved
Hide resolved
src/components/NoticeText/CampaignRegistration10DlcNoticeText.tsx
Outdated
Show resolved
Hide resolved
src/components/NoticeText/CampaignRegistration10DlcNoticeText.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Chrobot <[email protected]>
…rewired/Spoke into feat-add-10dlc-notices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds additional 10DLC notices, to give admins and owners better updates about where their instance is at in the registration process.
Motivation and Context
Closes #1632
How Has This Been Tested?
All notices except for toll free have been tested locally - against the Spoke Portal production API.
TODO before merging:
Screenshots (if appropriate):
Documentation Changes
Checklist: