Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(10dlc): add additional notices #1645

Merged
merged 14 commits into from
Aug 2, 2023
Merged

feat(10dlc): add additional notices #1645

merged 14 commits into from
Aug 2, 2023

Conversation

ajohn25
Copy link
Contributor

@ajohn25 ajohn25 commented Jul 27, 2023

Description

This adds additional 10DLC notices, to give admins and owners better updates about where their instance is at in the registration process.

Motivation and Context

Closes #1632

How Has This Been Tested?

All notices except for toll free have been tested locally - against the Spoke Portal production API.

TODO before merging:

  • Backfill profile channels into Spoke Portal production database
  • Test toll free notices

Screenshots (if appropriate):

image
image
image
image

Documentation Changes

Checklist:

  • My change requires a change to the documentation.
  • I have included updates for the documentation accordingly.

@ajohn25 ajohn25 requested review from hiemanshu, bchrobot and a team July 27, 2023 06:27
Copy link
Contributor

@lediur lediur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general notes and questions.

nit: would it make sense to extract pricing copy into shared components?

@ajohn25 ajohn25 merged commit 602e5d5 into main Aug 2, 2023
3 checks passed
@ajohn25 ajohn25 deleted the feat-add-10dlc-notices branch August 2, 2023 03:55
ajohn25 added a commit to With-the-Ranks/Spoke that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish 10DLC messaging service state for registration warning
3 participants