feat(mui-theme): add typography field to createTheme function #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went through each of the options in the admin sidebar just to make sure that the font change didn't throw any existing styling out of alignment, and didn't notice anything. If there's a particular area that anyone wants screenshots or video of, lmk and I can add it above |
ajohn25
approved these changes
Aug 7, 2023
kennyycheng
approved these changes
Aug 8, 2023
|
oh should this close #1657 ? |
hiemanshu
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds a typography field to the
createMuiThemeV1function inmui-theme.ts, which specifies the Karla font family for Spoke components that use the Material-Ui Typography componentMotivation and Context
It closes #1657
This was a request that was part of the feedback for #1641, (see here), but which deserves its own issue + pr
How Has This Been Tested?
Locally.
Screenshots (if appropriate):
Screen.Recording.2023-08-07.at.12.07.00.PM.mov
Documentation Changes
Checklist: