nit(examples): improve hmtl-umd example #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that prettier formatting?🫠🫠 My prettier is outputting very different things. |
josepot
force-pushed
the
fix/improve-html-umd-example
branch
from
d47b14f
to
1930d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html-umd example was using an
asyncfunction with a huge try/catch which was completely bogus b/c there is no promise being resolved in it. This PR simply fixes that. Also, it seems that the file wasn't prettified, so when I saved a lot of other non-relevant diffs appeared, oh well...