Fix benchmarks and CI #1240
Closed
Fix benchmarks and CI #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Nov 3, 2023
| @@ -194,6 +194,8 @@ mod proof_size_test { | |||
|
|
|||
| #[test] | |||
| fn proof_size_subcall_accounting_works() { | |||
| debug_assert!(false, "CI sound asleep"); | |||
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is currently not running the benchmark tests and does therefore not detect failure (as noticed on SE).
Further, it is running the tests with
--releaseand should therefore not checkdebug_asserts. This MR contains three changes: