Fix JSONRPC error codes to be the same as in geth

[fairax]

Changes JSONRPC error code for revertal to be 3 and default error code to be -32000 instead of -32603. This behavior is the same as in geth which is referring to https://github.com/ethereum/wiki/wiki/JSON-RPC-Error-Codes-Improvement-Proposal.

[cla-bot-2021]

User @fairax, please sign the CLA here.

[fairax]

/cla run-cla-check

[cla-bot-2021]

@fairax The commands could not be executed:

Access denied to command "run-cla-check"

[sorpaas]

/cla run-cla-check

[cla-bot-2021]

Queueing command execution: run-cla-check

[cla-bot-2021]

@sorpaas Command execution has finished.

[sorpaas]

Can you provide a better link for the "JSON RPC Error Codes Improvement Proposal"? That wiki page links to another website's wiki page, but it never mentions 32603.

[fairax]

Relevant line in geth code https://github.com/ethereum/go-ethereum/blob/093b2ac32ac96fdf89cd80ca8fe40cb9c9fc8f49/internal/ethapi/api.go#L1029.
And I believe it refers to https://github.com/ethereum/wiki/wiki/JSON-RPC-Error-Codes-Improvement-Proposal/174cbd27cbfa7411cfbbb990eaca0fd37d76a10b.

Error code -32603 is defined here as Internal error. And code 3 is defined as Execution error.
In geth error code -32603 is defined as errcodePanic. https://github.com/ethereum/go-ethereum/blob/093b2ac32ac96fdf89cd80ca8fe40cb9c9fc8f49/rpc/errors.go#L63

[nanocryk]

If there is no selector it is still a revert and thus should have error JSON_RPC_ERROR_REVERT instead of JSON_RPC_ERROR_DEFAULT, right?

[fairax]

Probably, but it is not how geth behaves. There are tests for different cases https://github.com/abdulgalimov/ethereum-and-unique-errors-analysis and for example call to method errRevert returns JSON_RPC_ERROR_REVERT but call to callZeroAddress returns JSON_RPC_ERROR_DEFAULT.