Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bridges integration-tests instructions #366

Merged

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 28, 2024

This PR adjusts the instructions on how to run bridges integration tests.

  • Does not require a CHANGELOG entry

Future improvements: paritytech/parity-bridges-common#3016

@bkontur
Copy link
Contributor Author

bkontur commented Jun 28, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) June 28, 2024 20:06
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite complicated and also raises the question why you need the sudo pallet with fast runtime? Let's merge this, but would be nice to improve this.

@bkontur
Copy link
Contributor Author

bkontur commented Jun 30, 2024

Looks quite complicated and also raises the question why you need the sudo pallet with fast runtime? Let's merge this, but would be nice to improve this.

Yes, you're right. That's why I created issue #3016. When we started with the zombienet bridges tests, preopen_hrmp stopped working at some point (more info). As a workaround, I used force_open_hrmp_channel because establish_system_channel didn't exist at that time. Sudo is needed for the init-bridge governance call from the relay, but that could probably be replaced with a genesis setup or with Chopsticks and governance call.

@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot fellowship-merge-bot bot merged commit b900992 into polkadot-fellows:main Jul 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants