Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Actualize polkaholic chains #10327

Closed
wants to merge 4 commits into from
Closed

Conversation

eapo
Copy link

@eapo eapo commented Mar 4, 2024

@TarikGul
Copy link
Member

TarikGul commented Mar 4, 2024

Running the linter should fix the failing tests

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter

@eapo eapo requested a review from TarikGul March 12, 2024 23:10
@TarikGul
Copy link
Member

Linter is still complaining about ordering.

@eapo
Copy link
Author

eapo commented Mar 13, 2024

I can't understand these Errors.. but it be done

/home/runner/work/apps/apps/packages/apps-config/src/links/polkaholic.ts
Error:   38:5  error  Expected object keys to be in ascending order. 'GM' should be before 'Genshiro'          sort-keys
Error:   51:5  error  Expected object keys to be in ascending order. 'KILT Spiritnet' should be before 'Kico'  sort-keys
Error:   79:5  error  Expected object keys to be in ascending order. 'Tanganika' should be before 'subzero'    sort-keys

@sourabhniyogi
Copy link
Contributor

Disabling Polkaholic support via #10360 -- we are refactoring into API only solutions since Subscan and polkadot.js serve the userbase adequately

@piggydoughnut
Copy link
Contributor

Closing as this seems to have been already resolved.

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants