Skip to content

Commit

Permalink
send ping before subscriptions
Browse files Browse the repository at this point in the history
  • Loading branch information
F-OBrien committed Aug 9, 2024
1 parent fc9a84e commit bc8215a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/extension-ui/src/Popup/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { settings } from '@polkadot/ui-settings';
import { AccountContext, ActionContext, AuthorizeReqContext, MediaContext, MetadataReqContext, SettingsContext, SigningReqContext } from '../components/contexts.js';
import { ErrorBoundary, Loading } from '../components/index.js';
import ToastProvider from '../components/Toast/ToastProvider.js';
import { subscribeAccounts, subscribeAuthorizeRequests, subscribeMetadataRequests, subscribeSigningRequests } from '../messaging.js';
import { ping, subscribeAccounts, subscribeAuthorizeRequests, subscribeMetadataRequests, subscribeSigningRequests } from '../messaging.js';
import { buildHierarchy } from '../util/buildHierarchy.js';
import Accounts from './Accounts/index.js';
import AccountManagement from './AuthManagement/AccountManagement.js';
Expand Down Expand Up @@ -98,12 +98,14 @@ export default function Popup (): React.ReactElement {
);

useEffect((): void => {
Promise.all([
// initially send a ping message to create a port that will be reused for subsequent
// messages. This ensure onConnect event is fired only once
ping().then(() => Promise.all([
subscribeAccounts(setAccounts),
subscribeAuthorizeRequests(setAuthRequests),
subscribeMetadataRequests(setMetaRequests),
subscribeSigningRequests(setSignRequests)
]).catch(console.error);
])).catch(console.error);

settings.on('change', (settings): void => {
setSettingsCtx(settings);
Expand Down

0 comments on commit bc8215a

Please sign in to comment.