Fix: forget account for legacy account without authorizedAccounts #1381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1376
I managed to reproduce, here are the details for this to happen:
authUrls
list, which means that you have ever connected at least an account to a dapp. Checkout commit 4edd9cd for instance.authUrls
, then you'll need to set the authorizations for this website again, as in, it used to be available for all accounts, now you need to specify. Doing so will setauthorizedAccounts
for this website.authorizedAccounts
that doesn't haveauthUrls
, then it'll crash.The fix is super simple once this is clear,
authorizedAccounts
can be undefined and shouldn't prevent us from removing an account.