chore: update module resolution to bundler

[ryanleecode]

Fixes: #1386

• Error boundary had a type export error so had to refactor it to functional component.
• adds jest/@types/jest to resolve compiler error after node resolution change.
• Replace usages of /// <reference types="@polkadot/dev-test/globals" /> with import '@polkadot/dev-test/globals.d.ts'; and adds 'import/extensions': 'off' to eslint config. This is required to resolve type issues.

---

import/extensions is also a useless eslint rule and will be superseded by native node esm resolution. see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/extensions.md#when-not-to-use-it

[TarikGul]

Why are we adding jest?

[ryanleecode]

compiler failing with : Cannot find name 'it'. Do you need to install type definitions for a test runner? Try npm i --save-dev @types/jestornpm i --save-dev @types/mocha. after i changed the node resolution

[TarikGul]

I think this is causing problems in others files with the defined custom global jest types referenced in @polkadot/dev-test.

[TarikGul]

@Tbaut Some eyes on this from you would be nice as well.

[TarikGul]

What types do you specifically need exported?

[ryanleecode]

What types do you specifically need exported?

Trying to import @substrate/smoldot-discovery in packages/extension, but i'm getting

Cannot find module '@substrate/smoldot-discovery' or its corresponding type declarations.
  There are types at '/home/ryan/Documents/Repositories/polkadot-js/extension/node_modules/@substrate/smoldot-discovery/dist/index.d.mts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.ts(2307)

[ryanleecode]

I can try scoping the moduleResolution update to just packages/extension

Nah doesnt work

[TarikGul]

What types do you specifically need exported?

Trying to import @substrate/smoldot-discovery in packages/extension, but i'm getting

Cannot find module '@substrate/smoldot-discovery' or its corresponding type declarations.
  There are types at '/home/ryan/Documents/Repositories/polkadot-js/extension/node_modules/@substrate/smoldot-discovery/dist/index.d.mts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.ts(2307)

I think this is an issue with smoldot-discovery and should be solved at that level no? Instead of completely changing the module resolution for one package in the extension? I would be weary of the potential downstream affects it would have since many wallets and users leverage the extension-* packages but additionally the overhead between @polkadot/dev-ts vs importing Jest. I just want to ensure we don't add any complexity to the already complex pjs repos.

In terms of adding @substrate/smoldot-discovery I am a little out of the loop on that - I think it would be a very large breaking change if it required making webrequests.

[ryanleecode]

Should be good now and have no side effects.

[TarikGul]

Nice changes, Thank you!

One last thing I would want to be sure of is the potential downstream affects of changing node -> Bundler. Do we know of any issues it could cause?

[ryanleecode]

Nice changes, Thank you!

One last thing I would want to be sure of is the potential downstream affects of changing node -> Bundler. Do we know of any issues it could cause?

The code we are emitting is the same so I think its fine; moduleResolution just affects how we resolve imports. module has an impact on what is emitted but we are already on EsNext.

And since we are using rollup, moduleResolution bundler is the way to go.

https://www.totaltypescript.com/concepts/option-module-must-be-set-to-nodenext-when-option-moduleresolution-is-set-to-nodenext#youre-using-the-wrong-moduleresolution

[TarikGul]

Thank you!

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.