Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "Chain Specific App" setting #1445

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Aug 13, 2024

This PR will allow for the use of the "Chain Specific App" setting. Before this can go in, polkadot-js/ui#804 must be merged and released in the UI.

closes: #1443

Copy link
Member

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul
Copy link
Member Author

Okay cool, tested for each case and they all passed, and added some better error handling for extra insight.

@TarikGul TarikGul merged commit 61060c6 into master Aug 13, 2024
4 checks passed
@TarikGul TarikGul deleted the tg-ledger-chain-specific branch August 13, 2024 18:22
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polkadot-js extension stopped working with non-polkadot ledger apps
3 participants