-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detecting direct access to base class state (4th defect type) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizruk
previously approved these changes
Apr 4, 2022
Please, add example(s) with explanation to the description of the PR. |
nikololiahim
previously approved these changes
Apr 4, 2022
analysis/src/main/scala/org/polystat/odin/analysis/EOOdinAnalyzer.scala
Outdated
Show resolved
Hide resolved
analysis/src/main/scala/org/polystat/odin/analysis/EOOdinAnalyzer.scala
Outdated
Show resolved
Hide resolved
analysis/src/main/scala/org/polystat/odin/analysis/stateaccess/DetectStateAccess.scala
Outdated
Show resolved
Hide resolved
…lystat/odin into direct_access_to_state_defect
Leosimetti
force-pushed
the
direct_access_to_state_defect
branch
from
May 8, 2022 19:11
690cacc
to
3722747
Compare
nikololiahim
previously approved these changes
May 15, 2022
nikololiahim
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Example of the defect
The proper way to change the state in the subclass
b
would be:An improper way to achieve the same functionality in subclass
bad
:More detailed information about the problem statement and implementation is available here.