Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SimplePass.Names unique for each function + rename prohibited names like "i" "x" "msg" "txt" #11

Open
dours opened this issue Nov 5, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@dours
Copy link
Collaborator

dours commented Nov 5, 2021

  1. Some very benign names (at least x, i, msg, txt) should not currently be used in EO code because of Argument name shadows return field name: is this a feature? objectionary/eo#416 , so a renaming is needed. Avoid these names in python tests before this issue is resolved.
  2. SimplePass.Names are used incorrectly now, because an empty object is created before all passes in AST.Parse.parse. A new object with all statically known names should be created instead for each function.
@dours dours added the bug Something isn't working label Nov 5, 2021
dours added a commit that referenced this issue Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant