Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: upgrade to 1.23.1 #345

Merged
merged 3 commits into from
Sep 8, 2022
Merged

envoy: upgrade to 1.23.1 #345

merged 3 commits into from
Sep 8, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Upgrade to envoy 1.23.0

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner August 23, 2022 19:03
@calebdoxsey calebdoxsey requested review from wasaga and removed request for a team August 23, 2022 19:03
desimone
desimone reviewed Aug 23, 2022
View reviewed changes
Copy link

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @wasaga

@wasaga
Copy link
Collaborator

wasaga commented Aug 30, 2022

holding it off by a few days to let bugfixes in first.

@wasaga
Copy link
Collaborator

wasaga commented Sep 5, 2022

blocked by envoyproxy/envoy#22261

@wasaga wasaga added the blocked PR/ISSUE is blocked by third party label Sep 5, 2022
@desimone
Copy link

desimone commented Sep 6, 2022

  • 2.3.1 Fixes this and can be merged.

pomerium/pomerium#3599

@wasaga wasaga changed the title envoy: upgrade to 1.23.0 envoy: upgrade to 1.23.1 Sep 7, 2022
@wasaga wasaga mentioned this pull request Sep 7, 2022
Closed
desimone
desimone reviewed Sep 8, 2022
View reviewed changes
Copy link

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the port allocation change?

@wasaga
Copy link
Collaborator

wasaga commented Sep 8, 2022

Did the port allocation change?

yes, in pomerium/pomerium#3590

@calebdoxsey calebdoxsey merged commit 2cc181c into main Sep 8, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/upgrade-envoy branch September 8, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone left review comments

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
blocked PR/ISSUE is blocked by third party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebdoxsey @wasaga @desimone