Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add cookie_same_site option #620

Merged
merged 4 commits into from
May 4, 2023
Merged

config: add cookie_same_site option #620

merged 4 commits into from
May 4, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add a new option to set the SameSite option on cookies. From pomerium/pomerium#4148

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label May 2, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner May 2, 2023 22:05
@calebdoxsey calebdoxsey requested review from wasaga and removed request for a team May 2, 2023 22:05
@wasaga
Copy link
Collaborator

wasaga commented May 3, 2023

need run make deployment to generate the deployment.yaml. this is failing pre-commit check

wasaga
wasaga requested changes May 3, 2023
View reviewed changes
apis/ingress/v1/pomerium_types.go Outdated Show resolved Hide resolved
@calebdoxsey calebdoxsey merged commit abd41c8 into main May 4, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/cookie-same-site branch May 4, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebdoxsey @wasaga