Upgrade controller-runtime to v0.15.0 and k8s api to v0.30.0 #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralicky
force-pushed
the
kralicky/upgrade-controller-runtime
branch
from
ae8f5cb
to
018ea2d
Compare
Some small refactors were made to the manager setup logic to account for breaking changes in controller-runtime, and to prepare for its upcoming generic builder api.
kralicky
force-pushed
the
kralicky/upgrade-controller-runtime
branch
from
018ea2d
to
8b64e88
Compare
wasaga
reviewed
May 2, 2024
wasaga
approved these changes
May 2, 2024
wasaga
reviewed
May 2, 2024
kralicky
force-pushed
the
kralicky/upgrade-controller-runtime
branch
from
91cca80
to
4b72477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some small refactors were made to the manager setup logic to account for breaking changes in controller-runtime, and to prepare for its upcoming generic builder api.
Related issues
#952
Checklist
improvement/bug/ etc)