Add test framework and basic test cases #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `make check` from the test/ subdirectory to run the tests. The basic test cases currently hardcode IP addresses that are known to be reputable or known spammer addresses. These test cases can be substituted with more robust implementations later.
|
Just pushed an updated patch with the following changes:
|
|
Thanks, I will look into this carefully tomorrow and comment / merge. There's a protocol change that needs to be reflected into the filter and very likely into the tests too. |
|
Well, all tests are versioned, so assuming that the protocol version will be bumped, we can relabel the current tests as legacy tests and create new tests for the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of a test suite. The dependence on the Sender Score of some hardcoded IP addresses is certainly not optimal but I don't see an easy and portable way to work around that. I am open to improvement suggestions. Once we agree on the framework, I'd be happy to provide more modules, such as tests for the whitelist feature.