-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hashbrown behind no_std
feature
#168
Conversation
Looks like this breaks |
Unfortunately I don't think we have a great way to do this with the current features, because (I didn't notice that Related to rust-lang/cargo#2980 |
Thinking about this some more, building with no default features doesn't make sense because either |
Having both an So I guess requiring either |
@ids1024 agreed, it would be great if we didn't need to have both. In case it isn't clear, both features already exist in cosmic-text, so this PR is just attempting to move |
Follow-up to #160 to gate hashbrown behind
no_std
by defaultcc @notgull please let me know if this is problematic for some reason