Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StrictMode to React component root #1403

Open
outoftime opened this issue Mar 30, 2018 · 1 comment
Open

Add StrictMode to React component root #1403

outoftime opened this issue Mar 30, 2018 · 1 comment
Labels
code quality good first issue help wanted

Comments

@outoftime
Copy link
Contributor

React 16.3 introduces <StrictMode>, which provides extra runtime warnings for deprecated or potentially buggy behavior. We should add it to the root component.
@meg2208 meg2208 mentioned this issue Apr 24, 2018
Closed
alexpelan added a commit to alexpelan/popcode that referenced this issue Aug 21, 2018
@alexpelan
Add React StrictMode Globally
1aab78f 
Seems to work, we get some console errors now.

Fixes: popcodeorg#1403
@alexpelan alexpelan mentioned this issue Aug 21, 2018
Open
@alexpelan alexpelan self-assigned this Aug 21, 2018
@alexpelan
Copy link
Contributor

blah. so every one of our StrictMode errors is currently caused by react-redux and our connected components. This is fixed in react-redux@next (see: reduxjs/react-redux#897 ). Unfortunately, Popcode doesn't seem to boot with this version of react-redux (see: reduxjs/react-redux#965 and others).

The good news is I think we can just wait for the next cut of react-redux, yarn add that, and we'll be good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@outoftime @alexpelan