Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept exploring what it would be like to migrate to CSS modules. In particular, it migrates all of the styles surrounding the console to CSS modules. The console is a good test area because it’s self-contained but still encompasses several components with various shared styles.
At this point my main takeaway is that I would like to try the same exercise with styled-components, as I felt that CSS modules have noticeable downsides. Sharing styles between different modules is awkward, as is introducing variants on base rulesets. At a higher level, the whole exercise of coming up with class names, applying them to elements, and then writing selectors with rulesets seems like overkill in a scenario when each selector is pretty clearly talking about a single element (or item in a collection of elements). I get the sense from reading its docs that styled-components addresses all of these pain points.
If we do move forward with CSS modules, though, this PR needs some work before merging:
expression
vs.row